Skip to content

Comments

feat: basic connection#2

Merged
Pertempto merged 7 commits intomainfrom
ae/first-try
Oct 10, 2025
Merged

feat: basic connection#2
Pertempto merged 7 commits intomainfrom
ae/first-try

Conversation

@Pertempto
Copy link
Member

@Pertempto Pertempto commented Oct 10, 2025

Basic system for answering a call.

For now, we just test basic TTS and prompting. Conference call logic will be later.

@github-actions
Copy link

The README describes setting up a LaML Application with a Request URL, but the code uses SignalWire's Realtime API instead. The Realtime API typically requires configuring the phone number to use the Relay context with your project credentials, not a LaML app. Please update the README to correct the setup instructions for Realtime API.

@github-actions
Copy link

In src/server.js, the code prompts the user to enter a 5-digit PIN, but the README example sets HOST_PIN to 4 digits (1234). Consider changing the prompt and max digits to 4 for consistency.

@github-actions
Copy link

The current implementation prompts users to enter a PIN, echoes it back, and hangs up without any conference logic. For a "basic connection" system, you might want to add initial steps like checking if the PIN is correct and proceeding to join or start a conference (using SignalWire's conference methods).

@github-actions
Copy link

Echoing the PIN back to the caller is not secure and could lead to unintended disclosure. Consider removing the playTTS line that repeats the PIN.

@github-actions
Copy link

There's a TODO in the code for adding error handling. Ensure to handle cases where the PIN prompt fails or the call encounters errors to make the system robust.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Changes Requested

Summary of Changes

  • Added infrastructure files (.dockerignore, .gitignore, Dockerfile, eslint.config.cjs, package.json).
  • Updated README with setup details.
  • Implemented initial call handling in src/server.js with PIN prompting, but no conference joining logic.

Overall Feedback

Strong start on the project foundations and build setup. However, the core conference functionality still needs to be added to make this a "basic connection" system—calls hang up after PIN entry without joining. Let's fix the PIN echo security issue, align digit counts, update the README for Realtime API, and implement the conference join logic as suggested in earlier comments. Keep up the good work! 🚀

@github-actions
Copy link

In src/server.js, the core conference functionality isn't implemented yet. After validating the PIN, the system should:

  • If PIN matches host PIN, mark conference as active and join the conference as presenter.
  • Otherwise, join as a muted participant if conference is active.
  • Use SignalWire conference methods like joining a conference room.
    This will enable the basic connection system as intended.

@Pertempto Pertempto merged commit cbe0fa4 into main Oct 10, 2025
1 check passed
@Pertempto Pertempto deleted the ae/first-try branch October 10, 2025 16:36
@Pertempto Pertempto restored the ae/first-try branch January 13, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant